Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

Conversation

@MarcMcIntosh
Copy link
Contributor

Fix(vscode) Cannot find module 'redux-persist/es/persistReducer' its corresponding type declarations this shouldn't be exported.

Description

un-needed type export causing vscode build to fail.

  • How did you solve it?
    Fixed by not exporting all types from services/refact.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, only code improvements)
  • Documentation update

How to Test

  • Step 1: checkout this repo, run npm run build, then npm link
  • Step 2: checkout vscode dev branch then run npm link refact-chat-js then npm run compile
  • It should compile :)

Screenshots (if applicable)

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated the documentation where necessary.

Linked Issues

Additional Notes

… its corresponding type declarations` this shouldn't be exported.
@MarcMcIntosh MarcMcIntosh merged commit 22b2f9b into alpha Feb 11, 2025
2 checks passed
@MarcMcIntosh MarcMcIntosh deleted the fix-type-exports-for-vscode branch February 11, 2025 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants