Skip to content

pinctrl: sunxi: sunxi_pinctrl_irq_ack avoid build warning #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smaeul merged 1 commit into from
Oct 12, 2021
Merged

pinctrl: sunxi: sunxi_pinctrl_irq_ack avoid build warning #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions drivers/pinctrl/sunxi/pinctrl-sunxi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,13 +1026,14 @@ static void sunxi_pinctrl_irq_ack(struct irq_data *d)
struct sunxi_pinctrl *pctl = irq_data_get_irq_chip_data(d);
u32 status_reg = sunxi_irq_status_reg(pctl->desc, d->hwirq);
u8 status_idx = sunxi_irq_status_offset(d->hwirq);
u32 new, old;

u32 old = readl(pctl->membase + status_reg);
old = readl(pctl->membase + status_reg);

/* Clear the IRQ */
writel(1 << status_idx, pctl->membase + status_reg);

u32 new = readl(pctl->membase + status_reg);
new = readl(pctl->membase + status_reg);

pr_err("acked %ld in 0x%08x, was 0x%08x, now 0x%08x\n",
d->hwirq, status_reg, old, new);
Expand Down