Smaato: Adapters that accept geolocation data from bid parameters sho…

…uld also accept it from ortb2.(device|user).geo (prebid#9676)
smaato · Mar 27, 2023 · 0968a38 · 0968a38
1 parent a6ef0c0
commit 0968a38
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 4 deletions.
diff --git a/modules/smaatoBidAdapter.js b/modules/smaatoBidAdapter.js
@@ -68,11 +68,23 @@ const buildOpenRtbBidRequest = (bidRequest, bidderRequest) => {
     deepSetValue(requestTemplate, 'regs.ext.gpp_sid', ortb2.regs.gpp_sid);
   }
 
+  if (ortb2.device?.ifa !== undefined) {
+    deepSetValue(requestTemplate, 'device.ifa', ortb2.device.ifa);
+  }
+
+  if (ortb2.device?.geo !== undefined) {
+    deepSetValue(requestTemplate, 'device.geo', ortb2.device.geo);
+  }
+
   if (deepAccess(bidRequest, 'params.app')) {
-    const geo = deepAccess(bidRequest, 'params.app.geo');
-    deepSetValue(requestTemplate, 'device.geo', geo);
-    const ifa = deepAccess(bidRequest, 'params.app.ifa');
-    deepSetValue(requestTemplate, 'device.ifa', ifa);
+    if (!deepAccess(requestTemplate, 'device.geo')) {
+      const geo = deepAccess(bidRequest, 'params.app.geo');
+      deepSetValue(requestTemplate, 'device.geo', geo);
+    }
+    if (!deepAccess(requestTemplate, 'device.ifa')) {
+      const ifa = deepAccess(bidRequest, 'params.app.ifa');
+      deepSetValue(requestTemplate, 'device.ifa', ifa);
+    }
   }
 
   const eids = deepAccess(bidRequest, 'userIdAsEids');

diff --git a/test/spec/modules/smaatoBidAdapter_spec.js b/test/spec/modules/smaatoBidAdapter_spec.js
@@ -356,6 +356,13 @@ describe('smaatoBidAdapterTest', () => {
             keywords: 'a,b',
             gender: 'M',
             yob: 1984
+          },
+          device: {
+            ifa: 'ifa',
+            geo: {
+              lat: 53.5488,
+              lon: 9.9872
+            }
           }
         };
 
@@ -368,6 +375,9 @@ describe('smaatoBidAdapterTest', () => {
         expect(req.user.ext.consent).to.equal(CONSENT_STRING);
         expect(req.site.keywords).to.eql('power tools,drills');
         expect(req.site.publisher.id).to.equal('publisherId');
+        expect(req.device.ifa).to.equal('ifa');
+        expect(req.device.geo.lat).to.equal(53.5488);
+        expect(req.device.geo.lon).to.equal(9.9872);
       });
 
       it('has no user ids', () => {
@@ -1007,6 +1017,28 @@ describe('smaatoBidAdapterTest', () => {
         expect(req.device.ifa).to.equal(DEVICE_ID);
       });
 
+      it('when geo and ifa info present and fpd present, then prefer fpd', () => {
+        const ortb2 = {
+          device: {
+            ifa: 'ifa',
+            geo: {
+              lat: 53.5488,
+              lon: 9.9872
+            }
+          }
+        };
+
+        const inAppBidRequest = utils.deepClone(inAppBidRequestWithoutAppParams);
+        inAppBidRequest.params.app = {ifa: DEVICE_ID, geo: LOCATION};
+
+        const reqs = spec.buildRequests([inAppBidRequest], {...defaultBidderRequest, ortb2});
+
+        const req = extractPayloadOfFirstAndOnlyRequest(reqs);
+        expect(req.device.geo.lat).to.equal(53.5488);
+        expect(req.device.geo.lon).to.equal(9.9872);
+        expect(req.device.ifa).to.equal('ifa');
+      });
+
       it('when ifa is present but geo is missing, then add only ifa to device object', () => {
         const inAppBidRequest = utils.deepClone(inAppBidRequestWithoutAppParams);
         inAppBidRequest.params.app = {ifa: DEVICE_ID};