Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: Replace 'package repo' with 'package registry', following the recommended terminology. #983

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

eruvanos
Copy link
Contributor

Replace 'package repo' with 'package registry', following the recommended terminology.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 6f71624
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/6525b5f938e0be000870f347
😎 Deploy Preview https://deploy-preview-983--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eruvanos
Copy link
Contributor Author

eruvanos commented Oct 10, 2023

Fix for #982
The PR does not change the current web content, but modifies spec version 1.1, images and the diagram file.

@eruvanos eruvanos changed the title Fix Issue #982 editorial: Replace 'package repo' with 'package registry', following the recommended terminology. Oct 10, 2023
Copy link
Member

@MarkLodato MarkLodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you so much for your contribution! There are some slight tweaks to make, but otherwise this change looks good.

docs/images/supply-chain-threats-build-verification.svg Outdated Show resolved Hide resolved
docs/_includes/use-cases-table.html Outdated Show resolved Hide resolved
docs/images/supply-chain-threats.svg Outdated Show resolved Hide resolved
docs/spec/v1.1/threats-overview.md Show resolved Hide resolved
@eruvanos
Copy link
Contributor Author

Applied the requested changes, please double check the right images are replaced now.

…and 1.1.

Revert changes in images of 0.1 and 1.0-rc*
Copy link
Member

@MarkLodato MarkLodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you so much!

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@eruvanos
Copy link
Contributor Author

@joshuagl anything missing from my side?

@joshuagl joshuagl merged commit 0052501 into slsa-framework:main Oct 13, 2023
5 checks passed
@joshuagl
Copy link
Member

Nothing missing, thanks again for the contribution @eruvanos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants