Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorial: tweak presentation of VSA pages #980

Merged
merged 1 commit into from
Oct 20, 2023
Merged

editorial: tweak presentation of VSA pages #980

merged 1 commit into from
Oct 20, 2023

Conversation

joshuagl
Copy link
Member

  • Expand VSA --> Verification Summary in the left-hand nav menu. The VSA acronym only makes sense to readers familiar with the VSA.
  • Remove redundant "SLSA" prefix from VSA page titles
  • Remove specification version from VSA page descriptions

@joshuagl
nonspec: tweak presentation of VSA pages
0d6a4b3 
- Expand VSA --> Verification Summary in the left-hand nav menu. The
  VSA acronym only makes sense to readers familiar with the VSA.
- Remove redundant "SLSA" prefix from VSA page titles
- Remove specification version from VSA page descriptions

Signed-off-by: Joshua Lock <joshuagloe@gmail.com>
@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 0d6a4b3
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/652519ef48e1ad00081fb5ed
😎 Deploy Preview https://deploy-preview-980--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joshuagl
Copy link
Member Author

Before:
Screenshot 2023-10-10 at 10 36 45

After:
Screenshot 2023-10-10 at 10 37 20

@MarkLodato MarkLodato changed the title nonspec: tweak presentation of VSA pages editorial: tweak presentation of VSA pages Oct 10, 2023
MarkLodato
MarkLodato approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@MarkLodato MarkLodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice!

(Note: I changed tag to editorial since it does touch a specification page.)

@joshuagl joshuagl requested a review from kpk47 October 12, 2023 10:17
@MarkLodato MarkLodato merged commit 105ecca into slsa-framework:main Oct 20, 2023
6 checks passed
@joshuagl joshuagl deleted the joshuagl/vsa-menu-expansion branch November 8, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLodato MarkLodato MarkLodato approved these changes

@mlieberman85 mlieberman85 Awaiting requested review from mlieberman85

@kpk47 kpk47 Awaiting requested review from kpk47

Assignees
No one assigned
Labels
None yet
Projects
Issue triage
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuagl @MarkLodato