Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl: add missing links in relatedwork doc #912

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

joshuagl
Copy link
Member

@joshuagl joshuagl commented Jul 10, 2023

The reference links for "Threats, Risks, and Mitigations in the Open Source Ecosystem" and
"Binary Authorization for Borg" were missing.

Signed-off-by: Joshua Lock <joshua.lock@uk.verizon.com>
@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for slsa canceled.

Name Link
🔨 Latest commit 0b149dd
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/64abfc2507cbd80008185060

Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We're also missing the link for "Binary Authorization for Borg" but this could be addressed in a different PR.

Signed-off-by: Joshua Lock <joshua.lock@uk.verizon.com>
@joshuagl
Copy link
Member Author

We're also missing the link for "Binary Authorization for Borg" but this could be addressed in a different PR.

Well spotted! I've pushed an extra patch to resolve that.

@joshuagl joshuagl changed the title impl: add missing link in relatedwork doc impl: add missing links in relatedwork doc Jul 10, 2023
Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuagl joshuagl merged commit 86e6347 into slsa-framework:main Jul 10, 2023
@joshuagl joshuagl deleted the joshuagl/missing-link branch July 10, 2023 13:13
kpk47 pushed a commit to kpk47/slsa that referenced this pull request Jul 11, 2023
The reference links for "Threats, Risks, and Mitigations in the Open
Source Ecosystem" and "Binary Authorization for Borg" were missing.

Signed-off-by: Joshua Lock <joshua.lock@uk.verizon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants