feat: Add notice if viewing outdated versions of the spec #862
Conversation
✅ Deploy Preview for slsa canceled.
|
ianlewis
force-pushed
the
version-warning
branch
4 times, most recently
from
776079e to
539b15d
Compare
ianlewis
requested review from
TomHennen,
MarkLodato,
mlieberman85 and
joshuagl
as code owners
There was a problem hiding this comment.
Thanks for proposing this @ianlewis! I think this is a great addition.
I wonder if we would be better off using the styling, and perhaps mechanism, of the existing "working draft" banner?
slsa/docs/_includes/header.html
Line 54 in d799c7b
We could use the same styling and mechanism but with a different message if status is retired vs. draft?
I redid the message to use this and allowed both the draft and new version message to be dismissed separately. I also updated the versions data to be a list rather than an object so it could be ordered. |
|
|
|
@joshuagl PTAL. I think I need your approval to merge. |
of pages linking them to the corresponding page in the newest version of the spec (or the top page if the page doesn't exist). Also removes older "Note about 0.x versions" which referenced v1.0 before it was released. Removed because notices at the top of the page should supersede them. Co-authored-by: Joshua Lock <joshuagloe@gmail.com> Signed-off-by: Ian Lewis <ianlewis@google.com>
When viewing older versions of the spec, this PR adds a notice at the top of pages linking them to the corresponding page in the newest version of the spec (or the top page if the page doesn't exist).
Also removes older "Note about 0.x versions" which referenced v1.0 before it was released. Removed because notices at the top of the page should supersede them.