fix: handle workflow input flag parsing#379
Merged
laurentsimon merged 2 commits intoslsa-framework:mainfrom Dec 2, 2022
Merged
fix: handle workflow input flag parsing#379laurentsimon merged 2 commits intoslsa-framework:mainfrom
laurentsimon merged 2 commits intoslsa-framework:mainfrom
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Contributor
Author
|
@laurentsimon I'd need this in the v2.0.1-rc! |
laurentsimon
approved these changes
Dec 2, 2022
nehtech9
approved these changes
Jun 19, 2024
sjn
reviewed
Jun 24, 2024
sjn
left a comment
sjn
left a comment
There was a problem hiding this comment.
This is a test review, from someone not involved in the project whatsoever. Please ignore!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug fix: this fixes a nil map entry assignment when creating workflow input flags.
Fixes slsa-framework/slsa-github-generator#1299
Signed-off-by: Asra Ali asraa@google.com