Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fixes, updates #354

Merged
merged 5 commits into from
Jun 20, 2022
Merged

minor fixes, updates #354

merged 5 commits into from
Jun 20, 2022

Conversation

chipzoller
Copy link
Contributor

@chipzoller chipzoller commented Jun 20, 2022 •
edited
Loading

  • Fixes broken links and a typo
  • Clarifies the expected format of the decoded value of the input base64-subjects.

Signed-off-by: Chip Zoller chipzoller@gmail.com

@chipzoller
minor fixes, updates
1956391 
Signed-off-by: Chip Zoller <chipzoller@gmail.com>
ianlewis
ianlewis approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@ianlewis ianlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

internal/builders/generic/README.md Outdated Show resolved Hide resolved
internal/builders/generic/README.md Outdated Show resolved Hide resolved
internal/builders/generic/README.md Outdated Show resolved Hide resolved
chipzoller and others added 3 commits June 20, 2022 09:49
@chipzoller
Update internal/builders/generic/README.md
085a98d 
Co-authored-by: Ian Lewis <ianlewis@google.com>
@chipzoller
Update internal/builders/generic/README.md
6e746b5 
Co-authored-by: Ian Lewis <ianlewis@google.com>
@chipzoller
Update internal/builders/generic/README.md
7d9ec61 
Co-authored-by: Ian Lewis <ianlewis@google.com>
@chipzoller
Copy link
Contributor Author

I've committed those suggestions. One other to consider is to clearly state that this assumes a Linux runner, perhaps one of a specific distribution. When I was testing this on my Mac locally, it does not have the program sha256sum and so calling out that this is a program for Linux which may deliver different results from other sha programs would be helpful.

@laurentsimon laurentsimon enabled auto-merge (squash) June 20, 2022 13:51
@laurentsimon laurentsimon merged commit cff06c1 into slsa-framework:main Jun 20, 2022
@ianlewis
Copy link
Member

I've committed those suggestions. One other to consider is to clearly state that this assumes a Linux runner, perhaps one of a specific distribution. When I was testing this on my Mac locally, it does not have the program sha256sum and so calling out that this is a program for Linux which may deliver different results from other sha programs would be helpful.

Yep that's a reasonable suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianlewis ianlewis ianlewis approved these changes

@asraa asraa Awaiting requested review from asraa

@laurentsimon laurentsimon Awaiting requested review from laurentsimon laurentsimon is a code owner

@joshuagl joshuagl Awaiting requested review from joshuagl joshuagl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chipzoller @ianlewis @laurentsimon