Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update changelog with unreleased changes #3263

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

ianlewis
Copy link
Member

Adds unreleased changes to the CHANGELOG to make it easier when doing the next release.

Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ianlewis ! That was on the back of my mind too
/cc @ramonpetgrave64

@laurentsimon laurentsimon enabled auto-merge (squash) February 20, 2024 10:00
@laurentsimon
Copy link
Collaborator

Let's try to do that in the PRs from now on. I have to admit I'm at fault here when doing reviews

@laurentsimon laurentsimon merged commit 5f89252 into slsa-framework:main Feb 20, 2024
74 checks passed
@ianlewis
Copy link
Member Author

Let's try to do that in the PRs from now on. I have to admit I'm at fault here when doing reviews

Yeah, it's easy to forget. We might consider adding a simple checklist to the PR description template as a reminder.

laurentsimon pushed a commit that referenced this pull request Feb 22, 2024
Adds a PR template as default PR description:

Hopefully this can also remind us to to keep docs up-to-date, as well,
like in #3263

---------

Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Co-authored-by: Ian Lewis <ianlewis@google.com>
ramonpetgrave64 added a commit to ramonpetgrave64/slsa-github-generator that referenced this pull request Feb 28, 2024
Adds a PR template as default PR description:

Hopefully this can also remind us to to keep docs up-to-date, as well,
like in slsa-framework#3263

---------

Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Co-authored-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64 added a commit that referenced this pull request Mar 20, 2024
ramonpetgrave64 added a commit that referenced this pull request Mar 20, 2024
ramonpetgrave64 added a commit that referenced this pull request Mar 20, 2024
This reverts commit 5f89252.

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants