Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Break out npm publish into separate action #2108

Merged
merged 38 commits into from
May 9, 2023
Merged

feat: Break out npm publish into separate action #2108

merged 38 commits into from
May 9, 2023

Conversation

ianlewis
Copy link
Member

@ianlewis ianlewis commented May 8, 2023

Breaks the npm publish step into a separate action. The action will download the package and attestation and run npm publish to publish to the npm registry.

Ian Lewis added 26 commits May 8, 2023 01:12
Separate out npm publish
4a69396 
Signed-off-by: Ian Lewis <ianlewis@google.com>
testing
b4ac881 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Add shell
1276b7e 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Add shell
dd6921e 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Add file name outputs
b54731c 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Add outputs
6debbb4 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Update inputs
1d7ce83 
Signed-off-by: Ian Lewis <ianlewis@google.com>
whitespace
6145707 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Fix tarball path
b756847 
Signed-off-by: Ian Lewis <ianlewis@google.com>
fix unused secrets
3cce4c3 
Signed-off-by: Ian Lewis <ianlewis@google.com>
fix inputs
2eed957 
Signed-off-by: Ian Lewis <ianlewis@google.com>
add debug
a4dc8e8 
Signed-off-by: Ian Lewis <ianlewis@google.com>
add debug
bbebe32 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Add path to secure-download-artifact
66ab180 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Update path
fede4b6 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Update inputs
58da2b8 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Update input names
56d05f9 
Signed-off-by: Ian Lewis <ianlewis@google.com>
fix output
0538c09 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Update attestation name
04a01de 
Signed-off-by: Ian Lewis <ianlewis@google.com>
add debug
c8b3df8 
Signed-off-by: Ian Lewis <ianlewis@google.com>
fix attestation paths
d556fcc 
Signed-off-by: Ian Lewis <ianlewis@google.com>
fix attestation name
1be979d 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Fix git errors
2b4f82f 
Signed-off-by: Ian Lewis <ianlewis@google.com>
update package path
262e229 
Signed-off-by: Ian Lewis <ianlewis@google.com>
remove debug
85ae936 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Update docs for Node.js builder
aee6642 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis marked this pull request as ready for review May 8, 2023 06:40
laurentsimon
laurentsimon approved these changes May 8, 2023
View reviewed changes
actions/nodejs/publish/action.yml Outdated Show resolved Hide resolved
actions/nodejs/publish/action.yml Show resolved Hide resolved
.github/workflows/builder_nodejs_slsa3.yml Show resolved Hide resolved
Ian Lewis added 10 commits May 8, 2023 22:42
Download to temp directory
39734f7 
Signed-off-by: Ian Lewis <ianlewis@google.com>
testing
2d65638 
Signed-off-by: Ian Lewis <ianlewis@google.com>
fix mktemp
0d8ef7e 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Allow download to temp directory
af3935c 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Add check for empty values
0869310 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Allow downloading to temp directories
ffb3bf5 
Signed-off-by: Ian Lewis <ianlewis@google.com>
fix path
0e4ddad 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Update pre-submits
1cd7588 
Signed-off-by: Ian Lewis <ianlewis@google.com>
remove testing references
263ac3a 
Signed-off-by: Ian Lewis <ianlewis@google.com>
Merge branch 'main' into npm-publish-refactor
d9ca2dd
@ianlewis ianlewis mentioned this pull request May 8, 2023
Merged
Ian Lewis added 2 commits May 9, 2023 01:42
Remove dup id
da6b44c 
Signed-off-by: Ian Lewis <ianlewis@google.com>
get runner_temp
832764c 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis merged commit af09839 into slsa-framework:main May 9, 2023
ianlewis pushed a commit that referenced this pull request May 9, 2023
chore: Release v1.6.0-rc.3 (#2095)
8ff4f7f 
#label:release v1.6.0-rc.3

We need to merge several PRs before this one:

- Revert references back to main: #2092 
- Fix for #2090
  - #2091
- #2094 
- #2093
- #2108 
- Optional: #2088
- Optional: #2089

---------

Signed-off-by: Ian Lewis <ianlewis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@asraa asraa Awaiting requested review from asraa

@joshuagl joshuagl Awaiting requested review from joshuagl joshuagl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianlewis @laurentsimon