refactor: Migrate go builder to WrappableError #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Kammel <fk@edgeless.systems>
datosh
requested review from
asraa,
ianlewis,
laurentsimon and
joshuagl
as code owners
ianlewis
changed the title
added 2 commits
January 31, 2023 18:25
Signed-off-by: Fabian Kammel <fk@edgeless.systems>
Signed-off-by: Fabian Kammel <fk@edgeless.systems>
|
I have reworked the tests as discussed @ianlewis based on the structure in I have defined the functions to check errors outside of the tests to keep the cognitive complexity value of the checker low. Also this allowed to reuse the same functions in |
ianlewis
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on this after discovering #599
I added two questions (as TODO prefixed code comments) where I was not sure which path is the better. Do you have any guidance?
Signed-off-by: Fabian Kammel fk@edgeless.systems