refactor: Update env vars included in provenance. #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Lewis <ianlewis@google.com>
ianlewis
force-pushed
the
runner-env-vars
branch
from
407b21a
to
6cf4728
Compare
ianlewis
requested review from
asraa,
laurentsimon and
joshuagl
as code owners
laurentsimon
approved these changes
Dec 9, 2022
ianlewis
commented
Dec 13, 2022
added 2 commits
January 10, 2023 06:24
Signed-off-by: Ian Lewis <ianlewis@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
CommandRunnerin two ways.PATHandPWDto be set properly for the environment.CommandSteporCommandRunner. Env vars copied from the builder's environment are not included in provenance for reproducibility. See [discussion] POSIX Environment Variables #822.Changes split out from #970
Signed-off-by: Ian Lewis ianlewis@google.com