builder: go: Allow equal signs in env vars #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
requested review from
asraa,
ianlewis,
laurentsimon and
joshuagl
as code owners
If .slsa-goreleaser.yml contains an env var with multiple '=' signs: ``` env: - CGO_ENABLED=1 - CGO_CFLAGS=-mmacosx-version-min=11.0 ``` the 'build dry project' GH workflow step fails with "invalid environment variable: CGO_CFLAGS=-mmacosx-version-min=11.0" This is caused by the way the env vars are parsed in GoReleaserConfig:setEnvs which only allow for a single '=' sign. This commit fixes this by splitting the env string at the first equal sign, first part is the env var name and won't contain '=' signs, second part is its value and can contain any number of '='. This also adds unit tests for this situation, and for env vars with no values (`CGO_CFLAGS=`). This fixes slsa-framework#1231 Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
|
Good, you allowed no value. 👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If .slsa-goreleaser.yml contains an env var with multiple '=' signs:
the 'build dry project' GH workflow step fails with "invalid environment
variable: CGO_CFLAGS=-mmacosx-version-min=11.0"
This is caused by the way the env vars are parsed in GoReleaserConfig:setEnvs
which only allow for a single '=' sign.
This commit fixes this by splitting the env string at the first equal sign,
first part is the env var name and won't contain '=' signs, second part
is its value and can contain any number of '='.
This also adds unit tests for this situation, and for env vars with no
values (
CGO_CFLAGS=).This fixes #1231