Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade upload/download-artifact in sync across all org #3239

Closed
mihaimaruseac opened this issue Jan 31, 2024 · 4 comments
Closed

Upgrade upload/download-artifact in sync across all org #3239

mihaimaruseac opened this issue Jan 31, 2024 · 4 comments
Labels
status:triage Issue that has not been triaged type:bug Something isn't working

Comments

@mihaimaruseac
Copy link
Contributor

Because upload-artifact and download-artifact are not compatible across v3-v4 major bump, we need to upgrade them across all repos at the same time, instead of when Renovate opens a PR in one repo.

Probably also need to cut new releases for that.
@mihaimaruseac mihaimaruseac added status:triage Issue that has not been triaged type:bug Something isn't working labels Jan 31, 2024
@mihaimaruseac mihaimaruseac mentioned this issue Jan 31, 2024
Closed
@mihaimaruseac
Copy link
Contributor Author

Opened slsa-framework/example-package#320 to also make sure the test repo is in the known.

mihaimaruseac added a commit to mihaimaruseac/model-transparency that referenced this issue Feb 6, 2024
@mihaimaruseac
Downgrade upload-artifact action to match SLSA
ba21963 
In slsa-framework/slsa-github-generator#3239 we have
that SLSA actions must match upload-artifact and download-artifact major
versions: v3 and v4 are not compatible. To reach that, we spent ~1 week of
debugging in SLSA. We're seeing the same here, as we upload with v4 but the
SLSA actions are downloading as v3. So we need to downgrade for now.

Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
@mihaimaruseac
Copy link
Contributor Author

It seems this is also affecting OSS project that have updated the actions (via Dependabot, etc.) so now are using upload-artifact@v4 in the release workflow. This is a ticking timebomb in all OSS projects :(

@behnazh-w
Copy link
Contributor

@mihaimaruseac We discussed this problem a month ago, which is still open: #3068

Indeed many releases have failed after upgrading download-artifact to v4.

@mihaimaruseac
Copy link
Contributor Author

Thank you. Closing this in favor of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:triage Issue that has not been triaged type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mihaimaruseac @behnazh-w