Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Support go-version-file in generate-builder #1807

Closed
ianlewis opened this issue Mar 13, 2023 · 0 comments · Fixed by #2156
Closed

[feature] Support go-version-file in generate-builder #1807

ianlewis opened this issue Mar 13, 2023 · 0 comments · Fixed by #2156
Labels
area:generate-builder Issue related to the generate-builder action area:tooling An issue with project tooling and config type:feature New feature or request

Comments

@ianlewis
Copy link
Member

ianlewis commented Mar 13, 2023 •
edited
Loading

Support the go-version-file input in generate-builder action to get the Go version from the go.mod file.

We have a lot of references to the Go version so it would be good to reduce that and manage it from the go.mod file.
@ianlewis ianlewis added type:feature New feature or request area:tooling An issue with project tooling and config area:generate-builder Issue related to the generate-builder action labels Mar 13, 2023
@ianlewis ianlewis mentioned this issue May 23, 2023
Merged
ianlewis pushed a commit that referenced this issue May 23, 2023
feat: Support go-version-file (#2156)
06f926f 
Fixes #1807

---------

Signed-off-by: Ian Lewis <ianlewis@google.com>
laurentsimon pushed a commit to laurentsimon/slsa-github-generator that referenced this issue Jun 1, 2023
@laurentsimon
feat: Support go-version-file (slsa-framework#2156)
9ad672c 
Fixes slsa-framework#1807

---------

Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: laurentsimon <laurentsimon@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:generate-builder Issue related to the generate-builder action area:tooling An issue with project tooling and config type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support go-version-file ianlewis/slsa-github-generator
1 participant
@ianlewis