Add test for Gradle builder#270
Merged
laurentsimon merged 15 commits intoslsa-framework:mainfrom Aug 17, 2023
Merged
Conversation
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
AdamKorcz
requested review from
asraa,
ianlewis,
joshuagl and
laurentsimon
as code owners
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
.github/workflows/e2e.gradle.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Not sure why shellcheck complains: I don't see any errors. |
Member
Yeah, don't worry about it for now. I'll take a look at it later. |
ianlewis
approved these changes
Aug 16, 2023
…sa3.yml Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
laurentsimon
approved these changes
Aug 17, 2023
laurentsimon
added a commit
to slsa-framework/slsa-github-generator
that referenced
this pull request
Aug 17, 2023
1. Add two public download actions 2. Add option for specifying a path to the Gradle project I found these changes to be necessary to run [the Gradle e2e test](slsa-framework/example-package#270). --------- Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com> Signed-off-by: AdamKorcz <adam@adalogics.com> Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a workflow_dispatch test for the Gradle builder.
It depends on a few changes to the builder that I will push shortly.