allow newer compilers#3
Conversation
|
Thanks @JJones780 for the PR. The status of a submodule is registered in Git by its commit hash. If you update the commit in the submodule, you can This is a way to ensure that the submodule is at a working version, which updating to the lastest version with |
README.md
Outdated
|
|
||
| ```bash | ||
| git submodule update --init | ||
| git submodule update --init --remote |
There was a problem hiding this comment.
Please update the submodule instead (see comment)
|
PS: For some reason the default branch was changed, I changed it back to master, please update your PR accordingly. Thanks :) |
…github (default branch settings) by Granjow.
|
commit f91: I removed the git submodule's --remote option in the build instructions. |
See Issue #2
It turns out the
git submodule updatewasn't getting the newest libsvflowThis required a change to the Readme instructions.
Once that was done there were a few directory issues with two CMakeLists.txt files.
No code changes were required.
Considerations for the README changes:
You might not want to pull the most recent submodule (in the future) - I didn't research how to set the version that the existing
git submodule update --recursivewas retrieving.