figma-inspector: x and y sometimes return null and until we have layout logic, make these 0 #8263
+63
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szecket
force-pushed
the
szecket/push-lxtozolnztwk
branch
from
025d6e9 to
a22cfb5
Compare
|
@tronical it appears I mixed up a little and had started doing some cleanup of sanitizers on this change already... |
|
Looks like this needs a rebase :) |
szecket
force-pushed
the
szecket/push-lxtozolnztwk
branch
from
171ae02 to
219fa8a
Compare
tronical
pushed a commit
that referenced
this pull request
Apr 28, 2025
…ve layout logic, make these 0 (#8263) * rounding was omitting a bunch of x and y positions * text x and y of 0 need to be checked for explicity otherwise they return null * clean up comments and console logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.