Node.js: Fix support for loadFile() with an URL on Windows #8235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
force-pushed
the
simon/nodejs-windows
branch
2 times, most recently
from
f4c96f9 to
dcfd73a
Compare
tronical
changed the title
We recommend the use of `loadFile(new URL("...", import.metal.url))`,
but this never worked on Windows, because we're not using the API
the Node.js docs even recommend to correctly covert to a local path on Windows.
(Apply the same logic to initTranslations)
Fixes #8209
tronical
force-pushed
the
simon/nodejs-windows
branch
from
dcfd73a to
e07b2d0
Compare
ogoffart
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recommend the use of
loadFile(new URL("...", import.metal.url)),but this never worked on Windows, because we're not using the API
the Node.js docs even recommend to correctly covert to a local path on Windows.
Fixes #8209