lsp/preview: fix selection of imported sub-components#11588
Open
0x6e wants to merge 1 commit intoslint-ui:masterfrom
Open
lsp/preview: fix selection of imported sub-components#115880x6e wants to merge 1 commit intoslint-ui:masterfrom
0x6e wants to merge 1 commit intoslint-ui:masterfrom
Conversation
`assign_is_in_root_component` compared `TextRange`s by raw byte offsets without checking the source file. When a component was imported from another file, byte ranges from that other file could numerically fall inside the root component's range, causing definition-site debug entries (e.g. a TouchArea inside an imported sub-component) to be flagged as "in the root component" and selected ahead of the actual use-site entry. Anchor on `(PathBuf, TextRange)` so out-of-file nodes are correctly rejected, and add a regression test that previously selected the imported TouchArea instead of the MyInput use site. Fixes slint-ui#11572. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
0x6e
force-pushed
the
feature/lsp-fix-selection-of-imported-components
branch
from
f4f4c52 to
d617bb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assign_is_in_root_componentcomparedTextRanges by raw byte offsets without checking the source file. When a component was imported from another file, byte ranges from that other file could numerically fall inside the root component's range, causing definition-site debug entries (e.g. a TouchArea inside an imported sub-component) to be flagged as "in the root component" and selected ahead of the actual use-site entry.Anchor on
(PathBuf, TextRange)so out-of-file nodes are correctly rejected, and add a regression test that previously selected the imported TouchArea instead of the MyInput use site.Fixes #11572.