Update README to show correct creation of extension #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a `Uri` object rather than a string and also show usage of PSR-11 method to retrieve from container. Closes #92
geggleto
reviewed
May 7, 2018
| $basePath = rtrim(str_ireplace('index.php', '', $c['request']->getUri()->getBasePath()), '/'); | ||
| $view->addExtension(new \Slim\Views\TwigExtension($c['router'], $basePath)); | ||
| $router = $c->get('router'); | ||
| $uri = Slim\Http\Uri::createFromEnvironment(new \Slim\Http\Environment($_SERVER)): |
Member
There was a problem hiding this comment.
Isn't the environment already registered in the container?
Member
Author
There was a problem hiding this comment.
I'm trying to discourage use of environment, request or response in the container as they won't be there in 4.
There was a problem hiding this comment.
note - there is a colon and not a semicolon at the end of line 34 in the readme file
geggleto
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
Uriobject rather than a string and also show usage of PSR-11method to retrieve from container.
Closes #92