Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Header by using PHP native types 🐘 #277

Merged
merged 7 commits into from
Mar 7, 2023
Merged

Improve Header by using PHP native types 🐘 #277

merged 7 commits into from
Mar 7, 2023

Conversation

nbayramberdiyev
Copy link
Contributor

@nbayramberdiyev nbayramberdiyev commented Feb 12, 2023 •
edited
Loading

This PR declares PHP native type for the parameter $values of the Header::addValues method, removes related test method and superfluous PHPDoc annotations. This way, we no longer need to manually check if the value is string or array.

@coveralls
Copy link

coveralls commented Feb 12, 2023 •
edited
Loading

Coverage Status

Coverage: 100.0%. Remained the same when pulling 7c83e37 on nbayramberdiyev:improve-header into bd76383 on slimphp:master.

@l0gicgate l0gicgate added this to the 1.7.0 milestone Mar 7, 2023
@l0gicgate
Copy link
Member

Thank you for this contribution @nbayramberdiyev

@l0gicgate l0gicgate merged commit a6f0cae into slimphp:master Mar 7, 2023
@nbayramberdiyev nbayramberdiyev deleted the improve-header branch March 7, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nbayramberdiyev @coveralls @l0gicgate