Some minor improvements

[williamdes]

About 966d0ff it is similar to phpmyadmin/sql-parser@a201314
In Debian we need the tests folder to run auto-package tests on packages.
Example: https://salsa.debian.org/php-team/pear/php-zumba-json-serializer/-/jobs/3521669#L312 or https://ci.debian.net/data/autopkgtest/unstable/amd64/p/phpmyadmin-sql-parser/27794800/log.gz

[williamdes]

Hi @l0gicgate

Can you review this in priority before the next release please ?
It is really important for me to be able to import your library into Debian: https://salsa.debian.org/php-team/pear/php-slim-psr7

And be able to package it. I can package it without tests, but you know it's not safe for end users, etc..

[coveralls]

Coverage: 100.0%. Remained the same when pulling f690015 on williamdes:improvements into a5327c8 on slimphp:master.

[l0gicgate]

@williamdes it appears that php nightly is not supported by our downstream dependencies at the moment. I don't mind having CI run against nightly but it makes it look like the PR is failing when it should not.

@akrabat any thoughts on this? Should we run against nightly on our other repos too or only add when we know our downstream deps have caught up?

[akrabat]

The PHP nightly test should be configured in our workflow to be allowed to fail really.

[akrabat]

The other changes in the PR look good to me.

[l0gicgate]

@akrabat unfortunately github actions don’t support us to allow failure for experimental matrixes 😕

There’s a long-standing issue about this that I’ve been tracking since 2020:
actions/runner#2347

I don’t mind adding it, it’ll look like every PR is failing though.

[akrabat]

Ah, right. Yes, this is fine as we can set the branch rules to allow merge regardless of whether nightly passes or not.

[akrabat]

Thanks @williamdes. Sorry that it took so long to get merged.

[williamdes]

thank you for merging this, it will help for the Debian packaging
It joined Debian with success: https://tracker.debian.org/pkg/php-slim-psr7
🎉