Fix StreamFactoryTest error #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0gicgate
previously approved these changes
Apr 26, 2021
l0gicgate
reviewed
Apr 26, 2021
src/Factory/StreamFactory.php
Outdated
Comment on lines
57
to
68
| // When fopen fails, PHP 7 normally raises a warning. Add an error | ||
| // handler to check for errors and throw an exception instead. | ||
| // On PHP 8, exceptions are thrown. | ||
| $exc = null; | ||
|
|
||
| // Would not be initialized if fopen throws on PHP >= 8.0 | ||
| $resource = null; | ||
|
|
||
| $errorHandler = function (string $errorMessage) use ($filename, $mode, &$exc) { | ||
| $exc = new RuntimeException(sprintf( | ||
| 'Unable to open %s using mode %s: %s', | ||
| $filename, | ||
| $mode, | ||
| $errorMessage | ||
| )); | ||
| }; | ||
|
|
||
| set_error_handler(function (int $errno, string $errstr) use ($errorHandler) { | ||
| $errorHandler($errstr); | ||
| }); | ||
| set_error_handler( | ||
| static function (int $errno, string $errstr) use ($filename, $mode): void { | ||
| throw new RuntimeException( | ||
| "Unable to open $filename using mode $mode: $errstr", | ||
| $errno | ||
| ); | ||
| } | ||
| ); | ||
|
|
||
| try { | ||
| $resource = fopen($filename, $mode); | ||
| } catch (ValueError $exception) { | ||
| $errorHandler($exception->getMessage()); | ||
| } | ||
| restore_error_handler(); | ||
|
|
||
| if ($exc) { | ||
| /** @var RuntimeException $exc */ | ||
| throw $exc; | ||
| } finally { | ||
| restore_error_handler(); | ||
| } |
There was a problem hiding this comment.
Can you explain how removing the catch fixes this? That makes the try statement obsolete since it'll never catch anything.
There was a problem hiding this comment.
Hi. Yes, you are right. I forgot to add catch to throw the exception. Fixed it.
l0gicgate
previously approved these changes
Apr 26, 2021
|
@l0gicgate the current version of slim/psr7 does not pass this test either. Because this test is incorrect. Expected exception "ValueError", but PSR-17 states that "createStreamFromFile" only throw "RuntimeException" or "InvalidArgumentException". Error message: I can fix this, but it is a PSR-17 violation. |
|
This discrepancy was fixed in http-interop/http-factory-tests v0. 9. 0 |
l0gicgate
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix phpstan error for php 8.0
Parameter #1 $callback of function set_error_handler expects (callable(int, string, string, int, array): bool)|null, Closure(int, string): void given.