This repository was archived by the owner on Dec 7, 2022. It is now read-only.
compatible with slime metric reconfiguration #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YonkaFang
reviewed
Nov 4, 2021
YonkaFang
reviewed
Nov 4, 2021
go.mod
Outdated
| slime.io/slime/framework => github.com/slime-io/slime/framework v0.3.1 | ||
| //slime.io/slime/framework => ../slime/framework | ||
| //slime.io/slime/framework => github.com/slime-io/slime/framework v0.3.1 | ||
| slime.io/slime/framework => ../slime/framework |
There was a problem hiding this comment.
replace back to a specific version
There was a problem hiding this comment.
will change after slime pr finished
There was a problem hiding this comment.
change to v0.3.3
cywang1905
force-pushed
the
master
branch
5 times, most recently
from
fd71e6e to
a0b2470
Compare
YonkaFang
reviewed
Nov 11, 2021
YonkaFang
reviewed
Nov 15, 2021
| //r.interestMeta.Pop(req.NamespacedName.String()) | ||
| delete(r.interestMeta, req.NamespacedName.String()) | ||
| for k, v := range r.interestMeta { | ||
| r.InterestMetaCopy[k] = v |
There was a problem hiding this comment.
changed according to concept of copy on write
| r.source.WatchAdd(types.NamespacedName{Name: instance.Name, Namespace: instance.Namespace}) | ||
| r.interestMeta[req.NamespacedName.String()] = true | ||
| for k, v := range r.interestMeta { | ||
| r.InterestMetaCopy[k] = v |
There was a problem hiding this comment.
m, mc map[string]string
func update() {
// ...
mut.Lock()
delete(m, "key1")
newMc := map[string]string{}
for k, v := range m {
newMc[key] = value
}
mc = newMc
mut.Unlock()
}
func GetM() map[string]string {
mut.RLock()
return mc
defer mut.RUnlock()
}
| // call back function for ticker producer | ||
| func (r *ServicefenceReconciler) handleTickerEvent(event trigger.TickerEvent) metric.QueryMap { | ||
| r.reconcileLock.RLock() | ||
| defer r.reconcileLock.RUnlock() |
There was a problem hiding this comment.
r.reconcileLock.RLock()
instMeta := r.interestMetaCopy
r.reconcileLock.RUnlock()
for ... {}| qm := make(map[string][]metric.Handler) | ||
| var hs []metric.Handler | ||
| for name, pHandler := range r.env.Config.Metric.Prometheus.Handlers { | ||
| query := strings.ReplaceAll(pHandler.Query, "$namespace", event.NN.Namespace) |
There was a problem hiding this comment.
we have two copies of this code block nearby
There was a problem hiding this comment.
replace by function generateHandler
YonkaFang
reviewed
Nov 15, 2021
cywang1905
changed the title
YonkaFang
approved these changes
Nov 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to slime-io/slime#110