Add regression test for capture handling in Rails #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timriley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @minad in judofyr/temple#112 (comment), here is a simple regression test intended to catch any issues around the specific intersection of Temple's capture handling and Slim's Rails-specific Temple generator.
Locally, I've tested this against:
gem 'temple', :github => 'judofyr/temple'gem "temple", github: "timriley/temple", branch: "propagate-options-to-capture-generator"(matching this PR: Use same capture_generator across nested captures judofyr/temple#144)And the test passes in both cases.
The goal of adding this test now is to build sufficient confidence before introducing this change to propagate options to nested capture_generators in Temple (judofyr/temple#144).
@minad — this is my first contribution to Slim. Please let me know if you'd like to see anything different here.