Update mistaken return from .catch().

slightlyoff · May 14, 2013 · df29df2 · df29df2
1 parent 543d7db
commit df29df2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/polyfill/src/Future.js b/polyfill/src/Future.js
@@ -303,12 +303,16 @@ Future.prototype = Object.create(null, {
                    wrap(onreject, r, "reject"), f);
     });
   }),
+  // FIXME(slightlyoff): it seems that returning self is a design error!
+  "catch": _public(function(onreject) {
+    var f = this;
+    return new Future(function(r) {
+      addCallbacks(null, wrap(onreject, r, "reject"), f);
+    });
+  }),
   "done": _public(function(onaccept, onreject) {
     return addCallbacks(onaccept, onreject, this);
   }),
-  "catch": _public(function(onreject) {
-    return addCallbacks(null, onreject, this);
-  }),
 });
 
 //

diff --git a/polyfill/tests/Future-tests.js b/polyfill/tests/Future-tests.js
@@ -117,9 +117,9 @@ t.add("Future", [
     t.t(f.done() === f);
   },
 
-  function catch_returns_self() {
+  function catch_does_not_return_self() {
     var f = new Future();
-    t.t(f.catch() === f);
+    t.t(f.catch() !== f);
   },
 
   async("Values forward correctly", function(d) {