Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hej folks,
while I wanted to work on this library for a proposed fix, I realized that the current linter setup was not actually linting TypeScript files. (I've screwed up this globbing vs.
--ext
a couple times myself 😅 )To make it easier to track the changes I've split up the work into multiple easy-to-review commits, and would recommend to not review
chore: ESLint autofixes
(0a5d8bd) as it exclusively enforces linting rules you've set up previously and they are tested by the ESLint autofix implementation.The two biggest changes are replacing a single
forEach
with afor-of
loop to fixno-unused-expressions
and introducing a newinnerComplexities
variables to fixno-param-reassign
.