Make the limit/offset API cleaner #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdevienne
force-pushed
the
limit-offset
branch
from
d4ac6d2
to
ca840ee
Compare
The 'Limit()' function of SelectStmt is misleading as it also sets the OFFSET. In some case we want thiner control on limit and offset, or not set both at the same time. The new functions consists of: - Limit(value) -> set LIMIT - Offset(value) -> set OFFSET - LimitOffset(limit, offset) -> set both LIMIT and OFFSET This change *breaks the API*
cdevienne
force-pushed
the
limit-offset
branch
from
ca840ee
to
4741c5f
Compare
|
Hi @aacanakin I am about to merge this PR which breaks the API Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Limit()' function of SelectStmt is misleading as it also sets the OFFSET.
In some case we want thiner control on limit and offset, or not set both
at the same time.
The new functions consists of:
This change breaks the API