Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version to srf datasets #8

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Add version to srf datasets #8

merged 5 commits into from
Sep 5, 2024

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Aug 31, 2024 •
edited
Loading

Add a version attribute to surface datasets that can be checked for compatibility in ctsm.

Fixes ESCOMP#2723

  • Update the comments in the glacier code to remove the bit about it being because surface dataset isn't compatible.

@ekluzek ekluzek added the enhancement New feature or request label Aug 31, 2024
@ekluzek ekluzek self-assigned this Aug 31, 2024
@ekluzek ekluzek changed the title Add version to srf datasets [WIP] Add version to srf datasets Aug 31, 2024
ekluzek
ekluzek commented Aug 31, 2024
View reviewed changes
src/main/surfrdMod.F90 Outdated Show resolved Hide resolved
ekluzek
ekluzek commented Sep 4, 2024
View reviewed changes
src/main/surfrdMod.F90 Outdated Show resolved Hide resolved
ekluzek
ekluzek commented Sep 4, 2024
View reviewed changes
src/main/surfrdMod.F90 Outdated Show resolved Hide resolved
slevis-lmwg
slevis-lmwg approved these changes Sep 4, 2024
View reviewed changes
Copy link
Owner

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekluzek and I looked this over, and I'm approving.

@ekluzek
Remove error about surface datasets
90a5cf0 
Remove the error messaging that talks about
old/incompatible surface dataset because we
now are checking for the surface dataset compatability.
@ekluzek
Add comments about dataset verison
703c291 
Add some notes that dataset version is only
updated when the new datasets will NOT be
backwards compatible with the previous
version.
@ekluzek
Change name of the subroutine for the surface dataset compatibility c…
0fd3d41 
…heck, fix version guessing inside it, fix spelling error, respond to rest of the review conversations
@ekluzek ekluzek changed the title [WIP] Add version to srf datasets Add version to srf datasets Sep 5, 2024
@ekluzek ekluzek merged commit 064886f into slevis-lmwg:new_rawpftlai Sep 5, 2024
1 check passed
@ekluzek ekluzek deleted the add_version_to_srf_datasets branch September 5, 2024 07:56
@slevis-lmwg slevis-lmwg mentioned this pull request Sep 11, 2024
Merged
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevis-lmwg slevis-lmwg slevis-lmwg approved these changes

Assignees

@ekluzek ekluzek

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekluzek @slevis-lmwg