Skip to content

Change hardcoded ports in firewalld.yml file #43

Open
@JensMKofoed

Description

Hi,

Many thanks for a wonderful role for installing and configure zookeeper. It saves my hours to write my own.
A suggestions is to change the hardcoded ports in the firewalld.yml file:
From:
name: Add firewalld rules
firewalld:
port: "{{ item }}"
permanent: yes
state: enabled
loop:
- 2181/tcp
- 2888/tcp
- 3888/tcp
notify: Reload firewalld

To:
name: Add firewalld rules
firewalld:
port: "{{ item }}"
permanent: yes
state: enabled
with_items:
- "{{ (zookeeper_client_port }}/tcp"
- "{{ zookeeper_leader_port }}/tcp"
- "{{ zookeeper_election_port }}/tcp"
notify: Reload firewalld

Kind regards
Jens M. Kofoed

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions