Skip to content

Commit

Permalink
Import Elvis 2.1_4 (written by Steve Kirkendall)
Browse files Browse the repository at this point in the history
  • Loading branch information
mbert committed Dec 10, 2011
1 parent 3a9bb55 commit 97d8998
Show file tree
Hide file tree
Showing 77 changed files with 3,030 additions and 746 deletions.
175 changes: 115 additions & 60 deletions BUGS
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,69 @@ NOTE: Not all of these are truly bugs. This file also serves as my "to do"
list, so some items are just unimplemented features that sounded like a good
idea at one time or another.

* There appears to be a bug in scanning -- a scanned block is not necessarily
-----------------------------------------------------------------------------
Fixed (or not) in version 2.1_4:

* Nested font changes don't always work correctly. For example,
"<strong><a href=foo>FOO!</a></strong> bar?" displays "bar?" in the
strong font. "<a href=foo><strong>Foo!</strong></a>" works though.

/ The built-in calculator's shell() function gives an ugly error message
if the safer option is set. It fails correctly; it simply looks ugly.

/ POSIX says that ^F/^B should leave two lines overlapping, not just one

/ POSIX says that $ should accept a count, and move forward (count-1) lines.

/ Executing ":do source somefile", where somefile contains an inner :while
loop, messes up the condition for the outer loop.

? The text-mode version of elvis sometimes has problems drawing characters
near the left edge of the window. Apparently it gets confused about where
the cursor is located.

I've seen this on some occasions, but I not recently. I've never
been able to reproduce it reliably. Perhaps it was a side-effect
of some other bug?

/ Under MS-DOS with TERM=nansi (and NANSI.SYS installed, of course) the screen
is shifted up one line. TERM=ansi works, but doesn't use nansi efficiently.

/ For gui="x11", if a window scrolls while some other window has pointer
focus, then the cursor isn't drawn. This is important when, e.g., you
use a dialog to search for text.

/ When the same buffer is shown in two windows, inserting text into one
window can cause the other to scroll. This seems to occur only when
the location of the change is above the top line of the other window.

Apparently what's happening is this: In a series of blank lines,
(i.e., lines which contain only a newline character), after any
character is inserted before line n, line n-1 has the same offset
than line n used to have, so the window update functions assume
that line n-1 is really still line n, so it shows line n-1 at the
top of the window instead of line n.

Probably the win->di->topline variable, which is currently a long
which stores an offset, should be replaced with a MARK. Since
MARKs are updated when a buffer changes, this should fix it.

* Given a URL such as "../untar.c", referenced from "/pub/elvis/unreleased",
elvis 2.1_3 tries to fetch "/pub/elvis/unreleased/../untar.c", but it *MUST*
be normalized as "/pub/elvis/untar.c" -- i.e., delete instances of "dir/../".
Some web servers depend on this.

? In "html" mode, if a single displayed line contains more than one link,
elvis always seems to follow the *last* link regardless of which one you
click on. This is bad for some menu bars.

Actually, this only seems to occur when multiple images appear
on a line, and you want to download one of the images. For
real links, elvis works correctly.

I took a stab at fixing this one. It seems better now.

? There appears to be a bug in scanning -- a scanned block is not necessarily
being locked for the whole time that it should be, which means that it may
be removed from the block cache, in which case NULL may be returned by some
of the blkXXXX() functions. Also, on at least one occasion elvis appeared
Expand All @@ -21,15 +83,60 @@ idea at one time or another.
recent attempts to make searches run faster by keeping at least one
scan context for the current location at all times.

/ One user reported crashes in WinElvis when the "Options->syntax" menu item
is activated while in "syntax" display mode.
The FEATURE_LITRE bug is fixed; hopefully that fixes this too.

* There are still problems with running external programs under Win32.
The :make command doesn't work. Also, the screen is sometimes messed up
after running a program.

I switched back to the older, more complex version of oswin32/osprg.c.
The only problem it has is that sometimes 16-bit filter programs don't
work correctly... but I just tested it again and that seems to work
now. Anyway, 16-bit filters are less important than :make, so I'm
keeping the older version.

/ When viewing an HTML document at a URL such as "http://foo/bar.html?boo/far",
containing a link to "zot.html", elvis will resolve that link to be to
"http://foo/bar.html?boo/zot.html", but it should be "http://foo/zot.html".

Similarly, I suspect that fileext() fails on URLs like that.

* One user reported that elvis was sensitive to keystrokes during quitting.
/ Hitting ^] on an operator doesn't search for an "operatorXX" tag? I
thought it did.

It appears to work now. I don't know why it didn't work before.

/ The alias.c program (which is compiled as vi.exe, ex.exe, and view.exe)
has been reported to cause problems under WindowsNT, and more recently
under Windows98 as well.

It appears that a Microsoft has introduced a bug into their versions
of the "exec" system calls. I switched to "spawn", which waits a
little RAM but seems to work correctly.

/ Under Windows95/98/NT, the "Terminal" font has funny spacing and sometimes
characters overlap each other.

This is a bug in the font, not in elvis. Elvis only supports
fixed-pitch fonts, and although "Terminal" claims to be fixed-pitch,
it is really a variable-pitch font.

/ Control chars in an alias aren't displayed in a printable form by the
:alias command. ":alias clean s/.^H//g" looks like "alias clean s///g".

/ Add VIM's "smarttab" option -- <Tab> keys at the beginning of a line act
like ^T, so they indent by the shiftwidth amount using a combination of
tabs and spaces. <Tab> keys elsewhere in a line are real tabs.

/ One user reported that elvis was sensitive to keystrokes during quitting.
I suspect that gui->poll was being called while the file was being written
(possibly just when written via FTP). That write should not be quittable.

* Under MS-DOS with TERM=nansi (and NANSI.SYS installed, of course) the screen
is shifted up one line. TERM=ansi works, but doesn't use nansi efficiently.
------------------------------------------------------------------------------
Fixed in 2.1_3

/ One user reported crashes in WinElvis when the "Options->syntax" menu item
is activated while in "syntax" display mode.

/ Can't identify tags whose whose contains a new-style comment. Apparently
the tag-selector can't parse \/\/ in an regular expression.
Expand Down Expand Up @@ -318,58 +425,9 @@ Fixed in 2.1j-beta....
/ Make elvis.arf strip off the perl version number from #!/usr/bin/perl-XXXX
lines. This makes syntax easier to recognize.
-------------
* Under X11, the XV button doesn't work. It reports that the temporary
file is empty.

The XV button does ":w !xv - >/dev/null 2>&1 &". The "x11" user
interface runs xv as a filter, so it can show the program's output
in the elvis window. Since xv doesn't output anything useful, I
tried to avoid that by running it in the background. However,
since pipes can fill up, elvis uses a temporary file for the filter's
stdin, and a pipe to read its stdout. Running a program in the
background like this causes elvis to read EOF from the filter's
stdout immediately, so elvis immediately clobbers the temp file.
The filter (xv) sees no data on its stdin. (Actually this is a
little surprising since elvis doesn't truncate the file; it deletes
it. A deleted file is *supposed* to remain allocated until the
last file descriptor on it is closed.)

The short-term fix is to avoid running filters in the background.

The long-term fix is to make the "x11" interface smarter about
running programs in the background, so it can use a pipe for stdin;
This would also allow the removal of ">/dev/null 2>&1".

* If xcurses exists, it should probably be used in preference to curses.
(This would be a change to the "configure" script.)

* In "html" mode, if a single displayed line contains more than one link,
elvis always seems to follow the *last* link regardless of which one you
click on. This is bad for some menu bars.

Actually, this only seems to occur when multiple images appear
on a line, and you want to download one of the images. For
real links, elvis works correctly. This bug can wait until
after 2.1 is done.

* For gui="x11", if a window scrolls while some other window has pointer
focus, then the cursor isn't drawn. This is important when, e.g., you
use a dialog to search for text.

* When the same buffer is shown in two windows, inserting text into one
window can cause the other to scroll. This seems to occur only when
the location of the change is above the top line of the other window.

Apparently what's happening is this: In a series of blank lines,
(i.e., lines which contain only a newline character), after any
character is inserted before line n, line n-1 has the same offset
than line n used to have, so the window update functions assume
that line n-1 is really still line n, so it shows line n-1 at the
top of the window instead of line n.

* Hitting ^] on an operator doesn't search for an "operatorXX" tag? I
thought it did.

? Elvis gets confused if you load a URL which has no filename component,
such as "http://www.yahoo.com". Adding a trailing slash avoids that.

Expand Down Expand Up @@ -680,7 +738,7 @@ Fixed in 2.1j-beta....
> like deducing them. What do you want to be done?

Apparently elvis needs to inspect the session's low-level buffers more
carefully before I restore them. In your session file, there is a
carefully before restoring them. In your session file, there is a
low-level buffer (at block 52) which contains a reference to a bogus
block number, and that's preventing you from restarting elvis to
recover the other buffers in that session file.
Expand Down Expand Up @@ -760,7 +818,7 @@ Fixed in 2.1j-beta....

In addition, a potential bug in the termcap interface was fixed.

* Some crashes/hangs have been reported under Linux. These may have something
? Some crashes/hangs have been reported under Linux. These may have something
to do with <u> and <Shift-U> commands. Usually there are no clues, but at
least twice the buffer filled with ^@ characters. Reported by Steve Woodard,
woodard@kodakr.kodak.com
Expand Down Expand Up @@ -872,9 +930,6 @@ Fixed in 2.1j-beta....
* In the installation routine, create links named "vi", "ex", and "view".
Similarly, supply .BAT files or something for Win32.

* Some problems have been reported while trying to recover files. Either
there's a bug, or I need to improve the documentation.

* Ctags doesn't produce "Mfilename" tags for main() functions in filename.c

* Sometimes text changes as you move the cursor over it in HTML mode. This
Expand Down
2 changes: 1 addition & 1 deletion COPYING
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Elvis 2.1 Copyright 1996 by Steve Kirkendall
Elvis 2.1 Copyright 1999 by Steve Kirkendall

Elvis 2.1 is copyrighted freeware. It is provided in the hope that it will
be useful, but with no warranty.
Expand Down
55 changes: 28 additions & 27 deletions INSTALL
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
HOW TO COMPILE & INSTALL ELVIS 2.1
HOW TO COMPILE & INSTALL ELVIS 2.1_4

Separate sets of instructions are provided below for UNIX, Windows-NT,
MS-DOS, and OS/2.
Expand All @@ -10,13 +10,24 @@ development environment if you prefer. Separate instructions are given
for both compilation methods, for both operating systems.

All of these instructions assume that you have already unpacked the files
from the source code archive, "elvis-2.1.tar.gz". That's a gzipped tar
from the source code archive, "elvis-2.1_4.tar.gz". That's a gzipped tar
archive. If you don't have the gzip and tar utilities, then the easiest
way for you to unpack them is to compile the "untar.c" program (available
via anonymous FTP from ftp://ftp.cs.pdx.edu/pub/elvis/untar.c). The files
will be placed in a subdirectory named "elvis-2.1". The MS-DOS *.MAK files
will be placed in a subdirectory named "elvis-2.1_4". The MS-DOS *.MAK files
assume that you've unpacked them while in C:\MSVC, so the files themselves
should end up in C:\MSVC\elvis-2.1.
should end up in C:\MSVC\elvis-2.1_4.

Under MS-DOS, the name of the archive will be mangled. It will probably
be "elvis-~1.gz", but it may be something else; the exact name depends on
how you downloaded it, and whether you already had an old version of that
archive in the same directory. The MS-DOS version of the "untar" program
needs to be passed the mangled name, whatever that turns out to be. The
Win32 version, on the other hand, can handle the full "elvis-2.1_4.tar.gz"
file name.

Also under MS-DOS, you may see complaints about some OS/2 files. You can
ignore that; you don't need those files to compile elvis for MS-DOS.

================================================================================

Expand Down Expand Up @@ -126,17 +137,7 @@ UNIX

================================================================================

NOTE FOR WINDOWS/NT: The "vi.exe", "ex.exe", and "view.exe" programs have been
reported to cause problems under NT. If they don't work on your system, then
I suggest you replace them with the equivalent batch files. Each batch file
would be just one line long:

vi.bat: elvis %1 %2 %3 %4 %4 %5 %6 %7 %8 %9
ex.bat: elvis -e %1 %2 %3 %4 %4 %5 %6 %7 %8 %9
view.bat: elvis -R %1 %2 %3 %4 %4 %5 %6 %7 %8 %9


MS-Windows/NT (or Windows95?), with Visual C++ 2.0 (Method #1):
MS-Windows/NT (or Windows95?), with Visual C++ 2.0 or later (Method #1):
1) Run the "makwin32.bat" file.

makwin32
Expand All @@ -153,7 +154,7 @@ MS-Windows/NT (or Windows95?), with Visual C++ 2.0 (Method #1):
copy lib\*.* \localbin\lib


MS-Windows/NT (or Windows95?), with Visual C++ 2.0 (Method #2):
MS-Windows/NT (or Windows95?), with Visual C++ 2.0 or later (Method #2):
1) Copy all of the "*.mak" files from files from the oswin32 subdirectory.

copy oswin32\*.mak
Expand Down Expand Up @@ -191,11 +192,11 @@ MS-Windows/NT (or Windows95?), with Visual C++ 2.0 (Method #2):
MS-DOS, using Visual C++ 1.5 (Method #1):
REMINDER: MSVC++ 1.5 always puts the complete pathnames of all files
into its NMAKE files. Because of this, you *MUST* install the
source code into a directory named "C:\MSVC\elvis-2.1". The
"elvis-2.1" component of that directory name is stored in the
"elvis-2.1.tar.gz" archive file, so you should be in the C:\MSVC
source code into a directory named "C:\MSVC\elvis-2.1_4". The
"elvis-2.1_4" component of that directory name is stored in the
"elvis-2.1_4.tar.gz" archive file, so you should be in the C:\MSVC
directory when you extract the files. After extracting the files,
do a "cd elvis-2.1"
do a "cd elvis-2.1_4"

1) Run the "makmsdos.bat" file

Expand All @@ -215,19 +216,19 @@ MS-DOS, using Visual C++ 1.5 (Method #1):
MS-DOS, using Visual C++ 1.5 (Method #2):
REMINDER: MSVC++ 1.5 always puts the complete pathnames of all files
into its NMAKE files. Because of this, you *MUST* install the
source code into a directory named "C:\MSVC\elvis-2.1". The
"elvis-2.1" component of that directory name is stored in the
"elvis-2.1.tar.gz" archive file, so you should be in the C:\MSVC
source code into a directory named "C:\MSVC\elvis-2.1_4". The
"elvis-2.1_4" component of that directory name is stored in the
"elvis-2.1_4.tar.gz" archive file, so you should be in the C:\MSVC
directory when you extract the files.

1) Copy all of the "C:\MSVC\elvis-2.1\OSMSDOS\*.MAK" files into the
"C:\MSVC\elvis-2.1" directory.
1) Copy all of the "C:\MSVC\elvis-2.1_4\OSMSDOS\*.MAK" files into the
"C:\MSVC\elvis-2.1_4" directory.

c:
cd \msvc\elvis-2.1
cd \msvc\elvis-2.1_4
copy osmsdos\*.mak

2) Copy the "\MSVC\elvis-2.1\OSMSDOS\OSCONFIG.H" file to
2) Copy the "\MSVC\elvis-2.1_4\OSMSDOS\OSCONFIG.H" file to
"\MSVC\elvis-2.1\CONFIG.H" Note that the "OS" is dropped from the
filename.

Expand Down
Loading

0 comments on commit 97d8998

Please sign in to comment.