This repository was archived by the owner on Jun 15, 2023. It is now read-only.
update pathy #44
Merged
update pathy #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safareli
commented
Feb 23, 2018
bower.json
Outdated
| @@ -17,7 +17,7 @@ | |||
| "dependencies": { | |||
| "purescript-prelude": "^3.1.0", | |||
| "purescript-matryoshka": "^0.3.0", | |||
| "purescript-pathy": "^4.0.0", | |||
| "purescript-pathy": "safareli/purescript-pathy#refactor", | |||
|
LGTM once we make the Pathy release 👍 |
cryogenian
reviewed
Mar 19, 2018
| @@ -36,7 +36,7 @@ type VariRelR = | |||
| } | |||
|
|
|||
| type TableRelR = | |||
| { path ∷ Pt.AnyFilePath | |||
| { path ∷ Pt.AnyFile | |||
There was a problem hiding this comment.
Would you mind make this Either AnyFile AnyPath or do you think this is matter of other pr?
E.g. marklogic directory querying
There was a problem hiding this comment.
I think other pr would be better for this :d
cryogenian
approved these changes
Mar 20, 2018
cryogenian
approved these changes
Mar 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.