Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build emscripten-snapshot-compiler without patching jerryscript #2

Merged
merged 5 commits into from
Nov 29, 2021

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Nov 27, 2021

This PR separates the snapshot compiler build from jerryscript by using pre-compiled libraries.

todo:

  • Generated code is slightly different to previously - there's an additional invoke_viii function in there but not sure why... Works fine though, leave it.
  • Add pre-compiled JSC for minimal/esnext profiles for application use (update Advanced sample accordingly)

@mikee47
Copy link
Contributor Author

mikee47 commented Nov 27, 2021

@slaff I've also removed the appveyor.yml from this because we can provide a generic script in the Sming repo. I'll have a separate PR for that.

@mikee47 mikee47 force-pushed the feature/no-patch branch 2 times, most recently from 3424880 to 8c01747 Compare November 29, 2021 11:23
@slaff
Copy link
Owner

slaff commented Nov 29, 2021

@mikee47 Ready with this PR?

@mikee47
Copy link
Contributor Author

mikee47 commented Nov 29, 2021

@slaff Yep, all done.

@@ -0,0 +1,88 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this file? I guess it was not meant to be part of this PR.

@slaff slaff merged commit bc6747b into slaff:master Nov 29, 2021
@mikee47 mikee47 deleted the feature/no-patch branch November 30, 2021 14:35
@mikee47
Copy link
Contributor Author

mikee47 commented Nov 30, 2021

@slaff I've got a version working with the current jerryscript master branch... See https://github.com/mikee47/Sming-jerryscript/tree/update/jerryscript-master

@slaff
Copy link
Owner

slaff commented Dec 1, 2021

@mikee47 Ok, we can merge these changes in the develop branch of Sming-jerryscript librabry. Is there improvement in speed, memory usage, snapshot size ?

@mikee47
Copy link
Contributor Author

mikee47 commented Dec 1, 2021

Generated sizes are similar and samples work correctly. I haven't done any speed tests but don't expect that to change. There are a lot of fixes and improvements but signficantly the API has changed. That means any work we do now should be compatible with the next release rather than having to apply it retrospectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants