-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build emscripten-snapshot-compiler without patching jerryscript #2
Conversation
@slaff I've also removed the appveyor.yml from this because we can provide a generic script in the Sming repo. I'll have a separate PR for that. |
52b89ef
to
1cb929c
Compare
3424880
to
8c01747
Compare
@mikee47 Ready with this PR? |
@slaff Yep, all done. |
@@ -0,0 +1,88 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this file? I guess it was not meant to be part of this PR.
8c01747
to
6fef20f
Compare
@slaff I've got a version working with the current jerryscript master branch... See https://github.com/mikee47/Sming-jerryscript/tree/update/jerryscript-master |
@mikee47 Ok, we can merge these changes in the |
Generated sizes are similar and samples work correctly. I haven't done any speed tests but don't expect that to change. There are a lot of fixes and improvements but signficantly the API has changed. That means any work we do now should be compatible with the next release rather than having to apply it retrospectively. |
This PR separates the snapshot compiler build from jerryscript by using pre-compiled libraries.
todo:
invoke_viii
function in there but not sure why... Works fine though, leave it.