Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mocking setup and added verification test for fault.py #16

Merged
merged 12 commits into from
Oct 30, 2024

Conversation

hmarts9
Copy link
Contributor

@hmarts9 hmarts9 commented Sep 25, 2024

This PR enhances the unit testing framework for the fault.py module by improving the mocking setup and adding a verification test. The main changes are:

  1. Updated mocking setup:

    • Implemented "patch.multiple" to mock both "get_data_at_time" and "get_values_over_time_range" functions from the archiver module.
  2. Added a verification test:

    • Introduced a new test method "test_mocks_are_applied()" to make sure that the mocking setup is working correctly.
    • This test checks that the mock objects have successfully replaced the original functions in the module.

Derikka and others added 2 commits September 24, 2024 14:10
@lisazacarias
Copy link
Collaborator

@hmarts9 can we resolve the merge conflicts and see if we can merge it in?

Copy link
Collaborator

@lisazacarias lisazacarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know what merge conflicts are left but the tests look great! Thanks again!

@hmarts9 hmarts9 merged commit b3b035c into main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants