Updates for rogue v6 #799
Draft
Updates for rogue v6 #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristpinsm
force-pushed
the
rogue_v6
branch
from
fe420f7 to
f6294bd
Compare
github-actions
bot
added
client
tristpinsm
force-pushed
the
rogue_v6
branch
2 times, most recently
from
3e8bba0 to
9f6bd88
Compare
Also make thread-aware.
Avoids client thread not getting stopped on exit.
- Revert "fix(SmurfBase): Access ZMQ client in context manager." - call the `stop` method after instantiation This reverts commit 0163064.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wide-ranging changes to the code to support a move to rogue v6. As of opening this draft, what has been tested includes
full_band_amplitude_sweepandfind_freqand both produce results consistent with the old code, with apparently improved performance.Changes in supporting code: