-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps and make task output dirs unique per task #77
Merged
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
f61be22
Gradle 7 m2
ZacSweers 1643b4a
Kotlin 1.4.31
ZacSweers 18f00ec
Make output dirs unique
ZacSweers a0a4532
Update CI, drop AGP 4.1 testing and add 7.0
ZacSweers 20fe309
More updates to CI
ZacSweers 28c0737
Update paths for l8 diagnostics
ZacSweers 8feeab5
Simplify diagnostic file names
ZacSweers 0a94225
More name simplifying
ZacSweers e5d40ed
More name simplification
ZacSweers ea4396a
Simplify CI matrix names
ZacSweers e6a0bb8
Use stable zipflinger 4.1.2 now
ZacSweers 3a8c610
Remove experimentalWarning
ZacSweers 0c95bb1
Update maven publish version
ZacSweers 5cf3eca
Make ZipSource instantiation compatible with multiple versions
ZacSweers 381b78f
Simplify another name
ZacSweers 92aa636
Don't declare a property
ZacSweers 24dbe32
Update name
ZacSweers 90d139b
Update desugar libs
ZacSweers b462336
Clean up instrumentation test runs a bit
ZacSweers aa5b106
Tweak running
ZacSweers 87aaa9b
Update to Gradle 7
ZacSweers 6a68045
Update all the versions
ZacSweers 04f4b8c
Disable logging for now because wtf?
ZacSweers f2dd7e0
Update more things
ZacSweers c2531b0
Try updating test libs? I mean, idk what else to do
ZacSweers 4287afe
Fix version
ZacSweers 9eefffa
androidTestUtil
ZacSweers c8899d2
Drop Proguard support
ZacSweers aace325
Restore version
ZacSweers c319494
Small cleanups
ZacSweers a3d3d64
Verify it works in one go
ZacSweers e68f296
verify
ZacSweers 41c0583
Gate verification on a flag
ZacSweers 4e811d0
Update androidx deps again
ZacSweers 4f90862
Update AGP
ZacSweers 657be0a
Fix l8 diagnostics
ZacSweers 6cde5e3
Fix missing dir creation
ZacSweers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update more things
- Loading branch information
commit f2dd7e0a0fddc23c9083eb20a0cadce397157154
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-all.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,37 +20,33 @@ import java.net.URL | |
plugins { | ||
`kotlin-dsl` | ||
`java-gradle-plugin` | ||
kotlin("jvm") version "1.4.32" | ||
kotlin("kapt") version "1.4.32" | ||
id("org.jetbrains.dokka") version "1.4.30" | ||
id("com.vanniktech.maven.publish") version "0.14.2" | ||
kotlin("jvm") version "1.5.0" | ||
kotlin("kapt") version "1.5.0" | ||
id("org.jetbrains.dokka") version "1.4.32" | ||
id("com.vanniktech.maven.publish") version "0.15.1" | ||
} | ||
|
||
buildscript { | ||
repositories { | ||
gradlePluginPortal() | ||
mavenCentral() | ||
jcenter() | ||
gradlePluginPortal() | ||
} | ||
} | ||
|
||
repositories { | ||
mavenCentral() | ||
google() | ||
gradlePluginPortal() | ||
jcenter().mavenContent { | ||
// Required for Dokka | ||
includeModule("org.jetbrains.kotlinx", "kotlinx-html-jvm") | ||
includeGroup("org.jetbrains.dokka") | ||
includeModule("org.jetbrains", "markdown") | ||
} | ||
} | ||
|
||
tasks.withType<KotlinCompile>().configureEach { | ||
kotlinOptions { | ||
jvmTarget = "1.8" | ||
@Suppress("SuspiciousCollectionReassignment") | ||
freeCompilerArgs += listOf("-progressive") | ||
// Because Gradle's Kotlin handling is stupid | ||
apiVersion = "1.4" | ||
languageVersion = "1.4" | ||
// @Suppress("SuspiciousCollectionReassignment") | ||
// freeCompilerArgs += listOf("-progressive") | ||
} | ||
} | ||
|
||
|
@@ -96,15 +92,15 @@ tasks.named<DokkaTask>("dokkaHtml") { | |
} | ||
} | ||
|
||
val defaultAgpVersion = "4.1.2" | ||
val defaultAgpVersion = "4.2.1" | ||
val agpVersion = findProperty("keeperTest.agpVersion")?.toString() ?: defaultAgpVersion | ||
|
||
// See https://github.com/slackhq/keeper/pull/11#issuecomment-579544375 for context | ||
val releaseMode = hasProperty("keeper.releaseMode") | ||
dependencies { | ||
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin-api:1.4.32") | ||
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.32") | ||
implementation("com.android:zipflinger:4.1.3") | ||
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin-api:1.5.0") | ||
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.5.0") | ||
implementation("com.android:zipflinger:4.2.1") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No longer shading this? 🆒 |
||
|
||
if (releaseMode) { | ||
compileOnly("com.android.tools.build:gradle:$defaultAgpVersion") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0-milestone-2-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-all.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D