Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Fixing the text input not being interactive since iOS 11 #624

Merged
merged 3 commits into from
Sep 22, 2017
Merged

Fixing the text input not being interactive since iOS 11 #624

merged 3 commits into from
Sep 22, 2017

Conversation

dzenbot
Copy link

@dzenbot dzenbot commented Sep 21, 2017

PR Summary

On iOS 11, both, UIToolbar and UINavigationBar have significantly changed internally, with a complete different view hierarchy, causing subclasses to behave strangely. In this case, there were new views laying above SLKTVC's outlets. Even tho #621 fixed it, it was more like a patch, causing us to bring SLKTVC outlets on front of every thing else, constantly.

Instead, we're making SLKTextInputbar a UIView subclass instead of UIToolbar. The only real reason why this has always been a UIToolbar subclass is because we wanted to mimic the same native look and feel of bottom bars, with the same background color and hairline.

Please gives this a try, and let us know of any issues with this fix asap, since this is the major bottleneck for fixing other iOS 11 bug related bugs.

Related Issues

Fixes #604
Closes #621

Ignacio Romero added 3 commits September 21, 2017 14:36
Fixed Xcode warnings + deprecating -shouldProcessTextForAutoCompletion:
e0c273c
Making SLKTextInputbar a UIView subclass instead, with its own hairli…
24f3fab 
…ne layout.

This fixes #604 rendering SLKTVC useless in iOS 11 since UIToolBar's view hierarchy has drastically changed since, conflicting with the internal outlets of SLKTextInputbar
Changelog
27168e0
@dzenbot dzenbot added the iOS 11 label Sep 21, 2017
@dzenbot dzenbot added this to the 1.9.6 milestone Sep 21, 2017
@dzenbot dzenbot mentioned this pull request Sep 21, 2017
Closed
6 tasks
@abildgaard
Copy link

abildgaard commented Sep 21, 2017 •
edited
Loading

Works for me in our application -- not a contributor but just a user of the library and unsure of what the official procedure for reviews is.

@abildgaard abildgaard mentioned this pull request Sep 21, 2017
Closed
4 tasks
cerupcat
cerupcat approved these changes Sep 21, 2017
View reviewed changes
Copy link

@cerupcat cerupcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing and working on iOS 11. Should be tested on previous versions as well.

@dzenbot
Copy link
Author

dzenbot commented Sep 21, 2017 •
edited
Loading

It's worth mentioning that I've tested this on iPhone 7/6s and iPad Air 2, using iOS 11 and iOS 10.3 simulators. Anyone with patience and devices, that could test this will get a 💯 badge ;)

@lauracpierre
Copy link

Did a few checks, but not many OS versions
iPod, iOS 9.3.5 ✅
iPhone 6, iOS 10.3.1 ✅
iPhone 7, iOS 10.3.1 ✅
iPhone 7Plus, iOS 10.3.1 ✅
iPhone 7Plus, iOS 11 ✅
iPad Air 2, iOS 11 ✅

@dzenbot
Copy link
Author

dzenbot commented Sep 22, 2017

That's great @lauracpierre! Was that on actual devices?

@lauracpierre
Copy link

Yes, sorry forgot to mention that

@dzenbot
Copy link
Author

dzenbot commented Sep 22, 2017

@lauracpierre Thank you!
image

@lauracpierre
Copy link

You weren't kidding 😅

@dzenbot
Copy link
Author

dzenbot commented Sep 22, 2017

I'm a man of my word 😆

TosinAF
TosinAF approved these changes Sep 22, 2017
View reviewed changes
Copy link
Contributor

@TosinAF TosinAF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Cheers for doing this.

@dzenbot dzenbot merged commit 46113e0 into master Sep 22, 2017
@dzenbot dzenbot deleted the ios11/text-input-bar-fix branch September 22, 2017 00:13
@abildgaard
Copy link

Thank you !!

@dzenbot
Copy link
Author

dzenbot commented Sep 22, 2017

We will be soon pushing a release, with all the iOS 11 bug fixes and polishing. See #607 (comment)

@abildgaard abildgaard mentioned this pull request Sep 22, 2017
Open
fans3210 added a commit to fans3210/SlackTextViewController that referenced this pull request Sep 25, 2017
@fans3210
follow slackhq#624 fix and change uitextinputbar to uiview instead of…
3f0edf4 
… uitoolbar
jakubpetrik pushed a commit to loopsocial/SlackTextViewController that referenced this pull request Sep 25, 2017
Fixing the text input not being interactive since iOS 11 (slackhq#624)
d670f73 
* Fixed Xcode warnings + deprecating -shouldProcessTextForAutoCompletion:

* Making SLKTextInputbar a UIView subclass instead, with its own hairline layout.
This fixes slackhq#604 rendering SLKTVC useless in iOS 11 since UIToolBar's view hierarchy has drastically changed since, conflicting with the internal outlets of SLKTextInputbar

* Changelog
@JFejza
Copy link

JFejza commented Sep 26, 2017

Works on our app too, at least on all iOS 11 simulators. Thanks for the fix! Will check the thread for the official release.

@dzenbot dzenbot mentioned this pull request Sep 26, 2017
Closed
@bogren bogren mentioned this pull request Oct 14, 2017
Closed
@softwaremills softwaremills mentioned this pull request Oct 17, 2017
Closed
@dzenbot dzenbot mentioned this pull request Oct 26, 2017
Merged
6 tasks
@DennisMostajo
Copy link

Hi everyone, I have the same issue on iOS 11, I updated my pod file to:
pod 'SlackTextViewController' ,:git => 'https://github.com/slackhq/SlackTextViewController'
and I tried too with:
pod 'SlackTextViewController', :git => 'https://github.com/slackhq/SlackTextViewController.git', :branch => 'master'
, and the Text Field input stills untouchable, the keyboard is not working or showing, I print logs if isUserInteractionEnabled and show me, YES, any help, please? thanks!

dzenbot pushed a commit that referenced this pull request Nov 1, 2017
Reverting #624 to be using UIToolbar again, specially for iPhone X co…
fa390ae 
…mpatibility so the bottom edge of the input bar expands to the bottom of the screen

Fixes #619
dzenbot pushed a commit that referenced this pull request Nov 2, 2017
@hipwelljo
Update bottom margin to accommodate iPhone X home indicator (#619)
37f91f2 
* Update bottom margin to accommodate iPhone X home indicator

* Skips the bottom safe area when the textinputbar is hidden

* Reverting #624 to be using UIToolbar again, specially for iPhone X compatibility so the bottom edge of the input bar expands to the bottom of the screen
Fixes #619

* [skip-ci] updating changelog
@dzenbot dzenbot mentioned this pull request Nov 2, 2017
Closed
@coolcool1994
Copy link

Yeah this fixed it for us: Recfive@2b4cee5

chauvincent pushed a commit to untitledstartup/SlackTextViewController that referenced this pull request Nov 8, 2017
@hipwelljo
Update bottom margin to accommodate iPhone X home indicator (slackhq#619
94eca29 
)

* Update bottom margin to accommodate iPhone X home indicator

* Skips the bottom safe area when the textinputbar is hidden

* Reverting slackhq#624 to be using UIToolbar again, specially for iPhone X compatibility so the bottom edge of the input bar expands to the bottom of the screen
Fixes slackhq#619

* [skip-ci] updating changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TosinAF TosinAF TosinAF approved these changes

@cerupcat cerupcat cerupcat approved these changes

Assignees
No one assigned
Labels
iOS 11
Projects
None yet
Milestone
1.9.6
Development

Successfully merging this pull request may close these issues.

iOS 11 breaks slacktextviewcontroller
8 participants
@dzenbot @abildgaard @lauracpierre @JFejza @DennisMostajo @coolcool1994 @cerupcat @TosinAF