Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Scroll up under inverted=NO when keyboard shows #530

Closed
wants to merge 7 commits into from

Conversation

zhubofei
Copy link

@zhubofei zhubofei commented Oct 16, 2016

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Scroll up to current place when keyboard shows

Related Issues

#466

@zhubofei
Copy link
Author

zhubofei commented Oct 16, 2016

Flaws:

  • There is still a magic number "64" in this solution. It is the height of the navbar.

@zhubofei
Copy link
Author

Fixes #466

@zhubofei
Copy link
Author

#542 is much better than my solution. I'll just close this PR.

@zhubofei zhubofei closed this Oct 29, 2016
@dzenbot
Copy link

dzenbot commented Oct 29, 2016

That's good to know. Thanks for the headups @zhubofei !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants