This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Supporting Attributed String in SLKTextView #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| - (NSRange)slk_insertText:(NSString *)text inRange:(NSRange)range | ||
| { | ||
| // Skip if the text is empty | ||
| if (text.length == 0) { |
There was a problem hiding this comment.
Probably best to check that text is not nil.
There was a problem hiding this comment.
Actually, nevermind. This param is nonnull.
| [super setText:text]; | ||
|
|
||
| if (text) { | ||
| [self setAttributedText:[[NSAttributedString alloc] initWithString:text]]; |
There was a problem hiding this comment.
Whenever we need to create an attributed string out of a string, with no attributes, let's take the textView's font and textColor properties so it renders with the expected default styling.
… logic, to get the default attributed string when using 'text' only.
|
👍 nice, thank you for cleaning it up! should we merge this? |
|
👍👍 |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to support attributed string in our SLKTextView to allow more stylization on the text we input. This PR will change SLKTextView to use NSAttributedString by default. To be backward compatible, all the original API will be preserved, and in places where we insert NSString for the text, the string will be converted into NSAttributedString without any attributes assigned to it.
There are additional API provided to allow ease of stylization.