This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Fix for slk_dismissTextInputbarIfNeeded #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eded. Use bottomMargin instead.
|
I like this! It is a cleaner fix than #448 |
|
@dzenbot it is battle tested with your super awesome QA :) |
|
@yury: This PR looks good. Before merging, could you please complete the Contributor License Agreement (CLA)? |
|
@dzenbot done |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix slk_dismissTextInputbarIfNeeded sets keyboardHC.constant to zero which is wrong if SLKTextViewController placed in UITabBarController.
Instead of 0 it is better to use slk_appropriateBottomMargin.
Fixes #467
Fixes #456