This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Animate views when switching from the a keyboard to a custom input view. - #416
Merged
Conversation
| // The animation happens in window coordinates (slides from right to left) but doesn't in the view controller's view coordinates. | ||
| if (!CGRectEqualToRect(beginFrame, endFrame)) | ||
| // Second condition: check if the height of the keyboard changed. | ||
| if (!CGRectEqualToRect(beginFrame, endFrame) || fabs(preKeyboardHeight - self.keyboardHC.constant) >= FLT_EPSILON) |
There was a problem hiding this comment.
Interesting! Is the difference really small as FLT_EPSILON?
Contributor
Author
There was a problem hiding this comment.
Just out of my habit when dealing with floating point numbers. 😛
As you mentioned, a direct comparison will do the work and there should not affect anything at UI level.
There was a problem hiding this comment.
hello
how you put custom view in keyboard place ?!
Contributor
Author
There was a problem hiding this comment.
@SLAMAKA You can do this by setting inputView to any kind of UIResponder.
Since this is not relevant to this pull request, could we move the discussion to a private email thread, feel free to drop me a message at m@cyhsu.me
Thanks.
|
Looks good! Thanks. |
Contributor
Author
|
@dzenbot Thank you! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I found there's a "jump" when setting the
inputViewproperty of the text view:It looks like the value of
UIKeyboardFrameBeginUserInfoKeyandUIKeyboardFrameEndUserInfoKeyare the same whenreloadInputViewsis called after setting a custominputView.So I add a condition to check if the height of the keyboard changed.
This is the result after the modification:
Looking forward to your feedback.