This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Center right button and update constraints when its size is changed #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -535,11 +538,8 @@ - (void)slk_didChangeTextViewContentSize:(NSNotification *)notification | |||
|
|
|||
| - (void)slk_setupViewConstraints | |||
| { | |||
| UIImage *leftButtonImg = [self.leftButton imageForState:UIControlStateNormal]; | |||
|
|
|||
There was a problem hiding this comment.
Why remove these?
This is still necessary to detect and adjust the left button.
There was a problem hiding this comment.
Are they needed there? The leftVerMargin generated from the UIImage size is not used when the constraints are set. It looks like the real adjustment is made in slk_updateConstraintConstants. Not sure, this was something I noticed while implementing the proper fix, not really needed for it to work.
There was a problem hiding this comment.
You're right. It's no longer used here anymore.
dzenbot
pushed a commit
that referenced
this pull request
Aug 7, 2015
Center right button and update constraints when its size is changed
|
Sorry for taking so much time to merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed, just like described in #57, that increasing the font size for the right button didn't update the already set constraints. That had the following effect in our case:
This fix uses KVO as proposed in the closed issue, but please feel free to give feedback.
Thanks a lot for this great library!