Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Commit

Permalink
Updating PR template and 1.9.6 changelog entries
Browse files Browse the repository at this point in the history
  • Loading branch information
Ignacio Romero committed Nov 1, 2017
1 parent e54d051 commit 4dc83a1
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 11 deletions.
6 changes: 3 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
* [ ] I've read and understood the [Contributing guidelines](https://github.com/slackhq/SlackTextViewController/blob/master/.github/CONTRIBUTING.md) and have done my best effort to follow them.
* [ ] I've read and agree to the [Code of Conduct](https://github.com/slackhq/SlackTextViewController/blob/master/.github/CODE_OF_CONDUCT.md).
* [ ] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
* [ ] I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
* [ ] I've written tests to cover the new code and functionality included in this PR.
* [ ] I've added a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
* [ ] I've listed my changes on the [Changelog(https://github.com/slackhq/SlackTextViewController/blob/master/CHANGELOG.md) file.
* [ ] I've read, agree to, and signed the [Contributor License Agreement (CLA)](https://docs.google.com/a/slack-corp.com/forms/d/1q_w8rlJG_x_xJOoSUMNl7R35rkpA7N6pUkKhfHHMD9c/viewform).

#### PR Summary
Expand All @@ -12,4 +12,4 @@
> e.g. Fixes #206 and closes #230
#### Test strategy
> e.g. Add tests around whatsit production.
> e.g. Add tests around whatsit production.
28 changes: 20 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,38 @@
# Change Log

## Version 1.9.6
## Version 1.9.6 (unreleased)

This release includes many iOS 11 and iPhone X hot fixes.

##### Features:
- Allowing color customization in typing indicator. By @dskatz22 (#613)
- Adding support for an optional view to host outlets under the text view. By @dzenbot (#562)
- Exposing auto-completion variables. By @dzenbot (#561)

##### Hot Fixes & Enhancements:
- Fixed the text input not being interactive on iOS. Making `SLKTextInputbar` a UIView subclass instead of `UIToolbar`.
- Fixed the text input not being interactive on iOS. Making `SLKTextInputbar` a UIView subclass instead of `UIToolbar`. By @dzenbot (#624)
- Fixed scroll view content inset adjustments on iOS 11. By @gim- (#643)
- Fixed compiler error in example app. By @BasThomas (#629)
- Fixed content offset for keyboard when uninverted. By @ZAndyL (#542)

##### Deprecation:
- Deprecated `-shouldProcessTextForAutoCompletion:` in favor of `-shouldProcessTextForAutoCompletion`

##### CI:
- Building the SlackTextViewController framework and running basic tests using BuddyBuild CI, against all PRs. By @dzenbot (#640)

## [Version 1.9.5](https://github.com/slackhq/SlackTextViewController/releases/tag/v1.9.5)

##### Features:
- Migrated the library to be using NSAttributedString underneath. The `text` property on `SLKTextView` uses a NSAttributedString representation based on its font and text color, and doesn't forward to super. By @jacywu07 (https://github.com/slackhq/SlackTextViewController/pull/501)
- Migrated the library to be using NSAttributedString underneath. The `text` property on `SLKTextView` uses a NSAttributedString representation based on its font and text color, and doesn't forward to super. By @jacywu07 (#501)
- As part of the migration to NSAttributedString, new helpers for attributed strings have been added to `SLKTextView+SLKAdditions`.
- Introduced a new API to end users to open the auto-completion mode with a given prefix. By @jacywu07 (https://github.com/slackhq/SlackTextViewController/pull/506)
- Exposed the private `cacheTextView` method. By @acandelaria1 (https://github.com/slackhq/SlackTextViewController/pull/513)
- Introduced a new API to end users to open the auto-completion mode with a given prefix. By @jacywu07 (#506)
- Exposed the private `cacheTextView` method. By @acandelaria1 (#513)

##### Hot Fixes & Enhancements:
- Updated the sample project to Swift 3! By @cyhsutw (https://github.com/slackhq/SlackTextViewController/pull/522)
- Added a property to allow the user to set how many lines of text SLKTextView's placeholder should have. By @jedmund (https://github.com/slackhq/SlackTextViewController/pull/505)
- Tweaked keyboard height calculations on invert mode. By @ZAndyL (https://github.com/slackhq/SlackTextViewController/pull/512)
- Updated the sample project to Swift 3! By @cyhsutw (#522)
- Added a property to allow the user to set how many lines of text SLKTextView's placeholder should have. By @jedmund (#505)
- Tweaked keyboard height calculations on invert mode. By @ZAndyL (#512)

## [Version 1.9.4](https://github.com/slackhq/SlackTextViewController/releases/tag/v1.9.4)
##### Hot Fixes & Enhancements:
Expand Down

0 comments on commit 4dc83a1

Please sign in to comment.