feat!: wrap payloads to send to a "method" with "token" or "webhook"#333
Merged
feat!: wrap payloads to send to a "method" with "token" or "webhook"#333
Conversation
also fix: were the inputs not being parsed in tests idkperhaps
Member
Author
|
@seratch @filmaj huge thanks to y'all and the many others who've shared feedback on these changes! 🙏 ✨ I'm feeling solid about these changes and with the tests above passing I think now's an alright time to merge! Going to revert the |
Member
Author
|
☝️ That failure's expected since the changes to |
This was
linked to
issues
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a handful of changes across this action in preparation for
@v2! - #312 ✨A few more changes might be needed, but I'm hoping this is in an alright place to test things! Most details are in the README but some testing notes are below 🙏 📚
One notable change from the proposal is the parsing of YAML values 😳 I stumbled across the
js-yamlpackage during development and am finding that it parses super well and makes it a bit easier to author workflows - it all seems like YAML but it's parsed as a string that's converted to JSON via YAML! I think it's neat, but open to all discussion on this!Planning to soon find ways to test this beyond local builds, but the steps for reviews can hopefully be helpful for testing things 🧪
Running experimental changes in a development or testing workspace
Check out the documentation in
.github/resources🙏 ✨Running experimental changes of this branch in real workflows can be done with this-
Preview
Here, the payload uses a
methodandtokenwith YAML values:This example POSTs the
payload-file-pathto thewebhookURL:Reviewers
From the kind reviewer, testing of all kinds is super appreciated! Using these changes with various
tokenandmethodcombinations, or testing edge cases with the payloads and inputs withwebhookare all things that have changed, as well as some of the documentation that goes with this 📚With this branch checked out, notes on testing and changing commands can be found as
resources:🔗 https://github.com/slackapi/slack-github-action/tree/v2-development/.github/resources
Notes
Todo
Stub IRL callings of the@slack/web-apiWebClientbuildstep back if it's now breaking - it does seem needed to avoid thenpm installin testing...thread_tsare being returned!pull_requestin CI - a final step!Requirements