Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Mar 25, 2021

Summary

This pull request fixes #982 - refer to the issue for details.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Mar 25, 2021
@seratch seratch added this to the 3.5.0 milestone Mar 25, 2021
@seratch seratch self-assigned this Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #984 (c57abbd) into main (67bac12) will increase coverage by 0.00%.
The diff coverage is 84.12%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #984   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files          94       94           
  Lines        8543     8588   +45     
=======================================
+ Hits         7453     7493   +40     
- Misses       1090     1095    +5     
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 94.49% <80.95%> (-0.31%) ⬇️
slack_sdk/web/client.py 96.00% <85.71%> (-0.34%) ⬇️
slack_sdk/web/legacy_client.py 95.87% <85.71%> (-0.34%) ⬇️
slack_sdk/socket_mode/builtin/internals.py 73.16% <0.00%> (+0.43%) ⬆️
slack_sdk/socket_mode/client.py 76.99% <0.00%> (+2.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67bac12...c57abbd. Read the comment docs.

@seratch seratch merged commit a5186f1 into slackapi:main Mar 25, 2021
@seratch seratch deleted the issue-982 branch March 25, 2021 22:01
@seratch seratch mentioned this pull request Apr 10, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality Version: 3x web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add admin.users.session.* API support

2 participants