Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Mar 19, 2021

Summary

The attachments document encourages having fallback field in each attachment: https://api.slack.com/reference/messaging/attachments#legacy_fields

This pull request resolves the missing fallback argument in BlockAttachment constructor.

Thanks @eddyg for the feedback: https://community.slack.com/archives/CHL4CLRCZ/p1616013860007200
(if you're interested in joining the Slack workspace, you can join the community from https://j.mp/community-slack-com)

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Mar 19, 2021
@seratch seratch added this to the 3.4.3 milestone Mar 19, 2021
@seratch seratch self-assigned this Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #979 (8c8ba34) into main (0ac8a0b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
+ Coverage   87.31%   87.34%   +0.02%     
==========================================
  Files          94       94              
  Lines        8541     8543       +2     
==========================================
+ Hits         7458     7462       +4     
+ Misses       1083     1081       -2     
Impacted Files Coverage Δ
slack_sdk/models/attachments/__init__.py 99.41% <100.00%> (+<0.01%) ⬆️
slack_sdk/socket_mode/builtin/internals.py 72.72% <0.00%> (-0.44%) ⬇️
slack_sdk/socket_mode/client.py 76.99% <0.00%> (+2.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac8a0b...8c8ba34. Read the comment docs.

Copy link
Contributor

@eddyg eddyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@seratch seratch merged commit 636cbc0 into slackapi:main Mar 22, 2021
@seratch seratch deleted the attachment-fallback branch March 22, 2021 00:47
@seratch seratch modified the milestones: 3.4.3, 3.5.0 Mar 30, 2021
@seratch seratch mentioned this pull request Apr 10, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants