Add the browser version link in redirect_uri web page #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
seratch
commented
Feb 24, 2021
| <body> | ||
| <h2>Thank you!</h2> | ||
| <p>Redirecting to the Slack App... click <a href="{url}">here</a></p> | ||
| <p>Redirecting to the Slack App... click <a href="{url}">here</a>. If you use the browser version of Slack, click <a href="{browser_url}" target="_blank">this link</a> instead.</p> |
Contributor
Author
There was a problem hiding this comment.
This is the only change affecting users. I would like to know better sentences for this if you have suggestions.
| app = Flask(__name__) | ||
| app.debug = True | ||
|
|
||
| import logging |
Contributor
Author
There was a problem hiding this comment.
this was just broken when I updated a few days ago 🤦
| scopes=scopes, | ||
| user_scopes=user_scopes, | ||
| ) | ||
| redirect_page_renderer = RedirectUriPageRenderer( |
Contributor
Author
There was a problem hiding this comment.
Updated the samples to use the renderer and I've verified the behavior with these two example apps.
seratch
force-pushed
the
add-browser-version-link
branch
from
9478b17 to
9b44e8d
Compare
Codecov Report
@@ Coverage Diff @@
## main #963 +/- ##
==========================================
- Coverage 87.34% 87.33% -0.02%
==========================================
Files 94 94
Lines 8521 8522 +1
==========================================
Hits 7443 7443
- Misses 1078 1079 +1
Continue to review full report at Codecov.
|
stevengill
approved these changes
Feb 24, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the default HTML page for successful Slack app installation. I got a feedback from a customer, saying the person uses only the browser version of Slack and the
slack://deep link navigation does not work for me at all. As this is a common use case, I see rooms for improvement on this feature.We may want to apply the same (or similar) change to
@slack/oauthnpm package and the Java SDK's default behavior.Category (place an
xin each of the[ ])/docs-src(Documents, have you run./docs.sh?)/docs-src-v2(Documents, have you run./docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python setup.py validateafter making the changes.