-
Notifications
You must be signed in to change notification settings - Fork 849
Set default_type for HeaderBlock text #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 87.02% 87.02%
=======================================
Files 30 30
Lines 3800 3800
Branches 341 341
=======================================
Hits 3307 3307
Misses 344 344
Partials 149 149
Continue to review full report at Codecov.
|
|
Per this comment I tried running: But got errors for both. Also, per the PR, I'm not sure how to apply these changes to the other branch(es) without making a new PR |
@fwump38 Is it possible to share the errors you've encountered? If it's |
seratch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for fixing this. I will apply the same change to |
|
The errors I got when running |
Summary
Fixes #851 (at least for the main branch. This change needs to be applied to v3 branch in
slackandslack_sdkrespective locations)Category (place an
xin each of the[ ])Requirements (place an
xin each[ ])python setup.py validateafter making the changes.